Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FileScope: apply renaming in get_contract_from_name() #1539

Closed
wants to merge 2 commits into from
Closed

FileScope: apply renaming in get_contract_from_name() #1539

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
df76dd7
FileScope: apply renaming in get_contract_from_name()
SheldonHolmgren Dec 31, 2022
bd14360
Remove redundant return
SheldonHolmgren Dec 31, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion slither/core/scope/scope.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,9 @@ def add_accesible_scopes(self) -> bool:

def get_contract_from_name(self, name: Union[str, Constant]) -> Optional[Contract]:
if isinstance(name, Constant):
return self.contracts.get(name.name, None)
name = name.name
if name in self.renaming:
name = self.renaming[name]
return self.contracts.get(name, None)
Comment on lines +98 to 101
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should only fallback to the renaming if the contract name is not found to minimize potential collisions.


# region Built in definitions
Expand Down