Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing_owner_check lint #71

Merged
merged 1 commit into from
Jan 12, 2024
Merged

Fix missing_owner_check lint #71

merged 1 commit into from
Jan 12, 2024

Conversation

S3v3ru5
Copy link
Contributor

@S3v3ru5 S3v3ru5 commented Jan 12, 2024

Updates the lint to ignore Signer, AccountLoader and Sysvar account types.

For expressions of type x.clone() where x is AccountInfo, lint considers both expressions x and x.clone() to refer to different accounts and expects the developers to perform the owner check using x expression and x.clone() expression. As both refer to same account, the lint is updated to ignore clone() expressions from checking.

@smoelius
Copy link
Member

This is looking good, IMHO.

@S3v3ru5 S3v3ru5 marked this pull request as ready for review January 12, 2024 13:40
@S3v3ru5 S3v3ru5 requested a review from smoelius January 12, 2024 13:40
Copy link
Member

@smoelius smoelius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@smoelius smoelius merged commit 3c7044b into master Jan 12, 2024
1 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants