do not invalidate filemetadata cache early (#4049)

Signed-off-by: Jörn Friedrich Dreyer <[email protected]>
cs3org · Jul 7, 2023 · d629240 · d629240
1 parent 2727f60
commit d629240
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/changelog/unreleased/do-not-invalidate-filemetdadata-cache-early.md b/changelog/unreleased/do-not-invalidate-filemetdadata-cache-early.md
@@ -0,0 +1,5 @@
+Enhancement: Do not invalidate filemetadata cache early
+
+We can postpone overwriting the cache until the metadata has ben written to disk. This prevents other requests trying to read metadata from having to wait for a readlock for the metadata file.
+
+https://github.com/cs3org/reva/pull/4049
diff --git a/pkg/storage/utils/decomposedfs/metadata/messagepack_backend.go b/pkg/storage/utils/decomposedfs/metadata/messagepack_backend.go
@@ -157,13 +157,8 @@ func (b MessagePackBackend) saveAttributes(ctx context.Context, path string, set
 		return err
 	}
 
-	// Invalidate cache early
-	_, subspan := tracer.Start(ctx, "metaCache.RemoveMetadata")
-	_ = b.metaCache.RemoveMetadata(b.cacheKey(path))
-	subspan.End()
-
 	// Read current state
-	_, subspan = tracer.Start(ctx, "os.ReadFile")
+	_, subspan := tracer.Start(ctx, "os.ReadFile")
 	var msgBytes []byte
 	msgBytes, err = os.ReadFile(metaPath)
 	subspan.End()