-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
http: ocdavsvc - add If-Not-Match header on PUT #4
Comments
@butonic is this still the case? |
there is still no if-not-match in https://github.com/cernbox/reva/blob/master/cmd/revad/svcs/httpsvcs/ocdavsvc/put.go - so I guess this is still the case .... |
@DeepDiver1975 @butonic thanks for the pointers, does ownCloud uses the ETAG as the entity or only uses the * case? |
Both cases are used . If-None with * to make sure a new resource is created and If-Match 'etag' to make sure we do not overwrite by accident |
no - there is no If-Not-Match in the mentioned PR - also commented accordingly https://github.com/cs3org/reva/pull/674/files#r413058259 |
If-Match is implemented - https://github.com/cernbox/reva/blob/a6be57bfedc01eddf38148bb7015c2fb8a7a0058/services/httpsvc/ocdavsvc/put.go#L151
To be capable to ensure that overwrite upon creating a new file is not possible the If-Not-Match header with the special value '*' should be implemented.
How does it work:
the client sends If-Not-Match: '*' with a request which shall create a new file. The server checks if the file does not exist otherwise 412 is returned.
The text was updated successfully, but these errors were encountered: