Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tests-only] Pin behat/gherkin because of Gherkin issue 187 #1419

Merged
merged 3 commits into from
Jan 25, 2021
Merged

[tests-only] Pin behat/gherkin because of Gherkin issue 187 #1419

merged 3 commits into from
Jan 25, 2021

Conversation

phil-davis
Copy link
Contributor

@phil-davis phil-davis commented Jan 25, 2021

Part of issue owncloud/core#38338 - currently CI for core API tests is broken because of the upstream Gherkin issue.

Pin behat/gherkin for now until Gherkin issue Behat/Gherkin#187 has been resolved.

@phil-davis phil-davis self-assigned this Jan 25, 2021
@phil-davis
Copy link
Contributor Author

phil-davis commented Jan 25, 2021

Note: this fixes the local API tests. Needs owncloud/core#38339 merged to get the version pinned for the core API test pipelines.

Edit: done in the 2nd commit

I will need to adjust expected-failures...

Edit: expected-failures have been adjusted

@phil-davis
Copy link
Contributor Author

@labkode @ishank011 CI should pass now. This gets CI green again. Please review.

@labkode labkode merged commit 8890f62 into cs3org:master Jan 25, 2021
@phil-davis phil-davis deleted the pin-behat-gherkin branch January 25, 2021 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants