Activate Statcache #2329
Activate Statcache #2329
Conversation
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
kobergj
force-pushed
the
activate-spaces-statcache
branch
from
831e6d7
to
dbe3605
Compare
kobergj
requested review from
glpatcern,
ishank011,
labkode and
a team
as code owners
| remove += "!" + res.StorageId + "!" + res.OpaqueId | ||
| } | ||
|
|
||
| for _, key := range cache.GetKeys() { |
There was a problem hiding this comment.
O(n)? It might be a niche, but couldn't this be O(1)? 🤔
There was a problem hiding this comment.
Maybe. But I'm not sure. We need to loop over all keys so we can check for prefixes. Any ideas?
There was a problem hiding this comment.
not really, I'd argue about using the OpaqueID as keys so it is a 1:1 match, but I think this is totally out of the scope of this. So you are forced to do this gymnastics around that 😓 because I doubt ttlcache is expressive enough to support queries to it.
There was a problem hiding this comment.
It isn't unfortunately. Removing keys by opaqueid doesn't work, because I need to have the option to remove all keys of a user, so we anyways loop over all keys.
No description provided.