Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tests-only] Spaces registry PR comments #2383

Merged
merged 2 commits into from
Dec 23, 2021

Conversation

kobergj
Copy link
Contributor

@kobergj kobergj commented Dec 17, 2021

Fixes comments from this PR: #2234

@kobergj kobergj mentioned this pull request Dec 17, 2021
@lgtm-com
Copy link

lgtm-com bot commented Dec 17, 2021

This pull request introduces 1 alert when merging bf4645f into 5744c56 - view on LGTM.com

new alerts:

  • 1 for Useless assignment to local variable

@kobergj
Copy link
Contributor Author

kobergj commented Dec 17, 2021

@refs Thanks for reviewing the spaces registry PR! I hope this fixes all points you mentioned.

See also #2372 for caching related comments

@butonic I couldn't answer some questions, can you please check #2234 (especially the comments where I mentioned you?)

@kobergj kobergj requested review from butonic and refs and removed request for labkode, glpatcern and ishank011 December 17, 2021 11:11
Signed-off-by: jkoberg <[email protected]>
@butonic butonic merged commit 7f0a043 into cs3org:edge Dec 23, 2021
@butonic
Copy link
Contributor

butonic commented Dec 23, 2021

thx for the cleanup

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants