Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjust permissions for deleting spaces #2828

Merged
merged 3 commits into from
May 6, 2022
Merged

Adjust permissions for deleting spaces #2828

merged 3 commits into from
May 6, 2022

Conversation

kobergj
Copy link
Contributor

@kobergj kobergj commented May 6, 2022

  • Do not allow viewers and editors to delete a space
  • Block deleting spaces via dav service (graph should be used)

@kobergj kobergj requested review from a team, labkode, ishank011 and glpatcern as code owners May 6, 2022 09:27
@kobergj kobergj requested review from butonic, C0rby, micbar, rhafer and wkloucek and removed request for labkode, glpatcern and ishank011 May 6, 2022 09:29
@kobergj kobergj mentioned this pull request May 6, 2022
Closed
micbar
micbar approved these changes May 6, 2022
View reviewed changes
Copy link
Member

@micbar micbar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

micbar
micbar requested changes May 6, 2022
View reviewed changes
Copy link
Member

@micbar micbar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the logic for the space root is not good enough.

@sonarcloud
Copy link

sonarcloud bot commented May 6, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@butonic butonic merged commit 62b6715 into cs3org:edge May 6, 2022
@kobergj kobergj mentioned this pull request Oct 14, 2022
Merged
@kiranparajuli589 kiranparajuli589 mentioned this pull request Oct 20, 2022
Merged
@kiranparajuli589 kiranparajuli589 mentioned this pull request Oct 28, 2022
Merged
@kobergj kobergj mentioned this pull request Dec 19, 2022
Merged
@kobergj kobergj mentioned this pull request May 22, 2023
Closed
@kobergj kobergj mentioned this pull request Jul 7, 2023
Closed
@kobergj kobergj mentioned this pull request Mar 1, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@micbar micbar micbar approved these changes

@butonic butonic Awaiting requested review from butonic

@C0rby C0rby Awaiting requested review from C0rby

@rhafer rhafer Awaiting requested review from rhafer

@wkloucek wkloucek Awaiting requested review from wkloucek

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kobergj @micbar @butonic