Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate space_ref, use space instead #2913

Merged
merged 2 commits into from
Jun 1, 2022
Merged

Deprecate space_ref, use space instead #2913

merged 2 commits into from
Jun 1, 2022

Conversation

kobergj
Copy link
Contributor

@kobergj kobergj commented Jun 1, 2022

The naming of the ocs API paramter space_ref was misleading. We decided to deprecate it and use space parameter instead. The difference is that space cannot contain a path, use path parameter instead

@kobergj kobergj requested review from a team, labkode and ishank011 as code owners June 1, 2022 12:37
@update-docs
Copy link

update-docs bot commented Jun 1, 2022

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@kobergj
changelog
ec245ec 
Signed-off-by: jkoberg <[email protected]>
@kobergj kobergj requested a review from glpatcern as a code owner June 1, 2022 12:40
@sonarcloud
Copy link

sonarcloud bot commented Jun 1, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@kobergj kobergj requested review from butonic and removed request for labkode, glpatcern and ishank011 June 1, 2022 12:42
@kobergj kobergj merged commit 0aa89cb into cs3org:edge Jun 1, 2022
@kobergj kobergj deleted the RenameSpaceRef branch June 1, 2022 13:26
@kobergj kobergj mentioned this pull request Oct 14, 2022
Merged
@kiranparajuli589 kiranparajuli589 mentioned this pull request Oct 20, 2022
Merged
@kiranparajuli589 kiranparajuli589 mentioned this pull request Oct 28, 2022
Merged
@kobergj kobergj mentioned this pull request Dec 19, 2022
Merged
@butonic butonic mentioned this pull request May 10, 2023
Closed
@kobergj kobergj mentioned this pull request May 22, 2023
Closed
@michaelstingl michaelstingl mentioned this pull request Aug 2, 2023
Closed
2 tasks
@kobergj kobergj mentioned this pull request Mar 1, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@micbar micbar micbar approved these changes

@butonic butonic butonic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kobergj @butonic @micbar