fix propfinds with depth 0

[C0rby]

Fixed the response for propfinds with depth 0. The response now doesn't contain the shares jail anymore.

Fixes: owncloud/ocis#3704

@butonic, can you please double check that this is indeed the fix.

[kobergj]

LGTM 👍

[butonic]

This approach omits stating the children and uses the virtual share jail as is. But the virtual share jail does not have a proper etag and mtime ...

well, /dav/spaces/{sharejailid} now need to see all mountpoints as well, which means the share jail now has to calculate etag end mtime for the root anyway. So this might actually be the fix ... but for depth 0 we still need to aggregate the mtimes, size and use the most recent etag...

[C0rby]

This approach omits stating the children and uses the virtual share jail as is. But the virtual share jail does not have a proper etag and mtime ...

Do you mean stating the children of the virtual share jail?

So this might actually be the fix ... but for depth 0 we still need to aggregate the mtimes, size and use the most recent etag...

Isn't this happening here?

reva/internal/http/services/owncloud/ocdav/propfind/propfind.go

Lines 448 to 461 in 2c1792e

	if mostRecentChildInfo != nil {
	if rootInfo.Mtime == nil || (mostRecentChildInfo.Mtime != nil && utils.TSToUnixNano(mostRecentChildInfo.Mtime) > utils.TSToUnixNano(rootInfo.Mtime)) {
	rootInfo.Mtime = mostRecentChildInfo.Mtime
	if mostRecentChildInfo.Etag != "" {
	rootInfo.Etag = mostRecentChildInfo.Etag
	}
	}
	if rootInfo.Etag == "" {
	rootInfo.Etag = mostRecentChildInfo.Etag
	}
	}
	// add size of children
	rootInfo.Size += aggregatedChildSize

[C0rby]

I have now finally looked through the code again and I think that this is indeed the fix we need.

This approach omits stating the children and uses the virtual share jail as is.

We are receiving all spaces, including the mountpoints, and are aggregating their sizes which then are added to the root. So nothing is omitted AFAIU.

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information

[C0rby]

Oh wait, I still need to test this with subfolders. I only tested it with the root folder.

[C0rby]

Oh wait, I still need to test this with subfolders. I only tested it with the root folder.

This still worked.