Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EOS spaces implementation #2919

Merged
merged 11 commits into from
Jun 3, 2022
Merged

EOS spaces implementation #2919

merged 11 commits into from
Jun 3, 2022

Conversation

ishank011
Copy link
Contributor

No description provided.

@ishank011 ishank011 marked this pull request as ready for review June 3, 2022 08:09
@ishank011 ishank011 requested review from labkode, glpatcern and a team as code owners June 3, 2022 08:09
@ishank011
Copy link
Contributor Author

@butonic can we merge this? The code smells are mostly from the existing codebase

@ishank011 ishank011 mentioned this pull request Jun 3, 2022
Closed
@butonic butonic mentioned this pull request Jun 3, 2022
Merged
@butonic
Copy link
Contributor

butonic commented Jun 3, 2022 •
edited
Loading

I triggered a ci run in ocis with this branch: owncloud/ocis#3922 it covers some more web cases, eg. for archives.

let's see how it goes... 🤞

@ishank011
Copy link
Contributor Author

@butonic all tests passed in the ocis repo. Can we merge?

@sonarcloud
Copy link

sonarcloud bot commented Jun 3, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 36 Code Smells

No Coverage information No Coverage information
4.1% 4.1% Duplication

@butonic butonic merged commit 78f443b into cs3org:edge Jun 3, 2022
@kobergj kobergj mentioned this pull request Oct 14, 2022
Merged
@kiranparajuli589 kiranparajuli589 mentioned this pull request Oct 20, 2022
Merged
@kiranparajuli589 kiranparajuli589 mentioned this pull request Oct 28, 2022
Merged
@kobergj kobergj mentioned this pull request Dec 19, 2022
Merged
@kobergj kobergj mentioned this pull request May 22, 2023
Closed
@kobergj kobergj mentioned this pull request Mar 1, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glpatcern glpatcern glpatcern approved these changes

@butonic butonic butonic approved these changes

@labkode labkode Awaiting requested review from labkode labkode is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ishank011 @butonic @glpatcern