Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API Cleanup: SpaceID #3006

Merged
merged 12 commits into from
Jul 12, 2022
Merged

API Cleanup: SpaceID #3006

merged 12 commits into from
Jul 12, 2022

Conversation

micbar
Copy link
Member

@micbar micbar commented Jun 23, 2022

Description

Implement cs3org/cs3apis#174

New ResourceID

// A resource id uniquely identifies a
// resource in the storage provider namespace.
// A ResourceId MUST be unique in the storage provider.
type ResourceId struct {
	// REQUIRED.
	// The logical id of a storage. Used by the storage
	// registry to determine the responsible storage provider.
	StorageId string `protobuf:"bytes,1,opt,name=storage_id,json=storageId,proto3" json:"storage_id,omitempty"`
	// REQUIRED.
	// The internal id used by service implementor to
	// uniquely identity the resource in the internal
	// implementation of the service.
	OpaqueId string `protobuf:"bytes,2,opt,name=opaque_id,json=opaqueId,proto3" json:"opaque_id,omitempty"`
	// OPTIONAL.
	// The internal id used by service implementor to
	// uniquely identify the storage space.
	// Used by the storageprovider to locate the correct storage space.
	SpaceId              string   `protobuf:"bytes,3,opt,name=space_id,json=spaceId,proto3" json:"space_id,omitempty"`
	XXX_NoUnkeyedLiteral struct{} `json:"-"`
	XXX_unrecognized     []byte   `json:"-"`
	XXX_sizecache        int32    `json:"-"`
}
provider.ResourceId{
                        StorageId: "provider-1",
			SpaceId:  "f7fbf8c8-139b-4376-b307-cf0a8c2d0d9c",
			OpaqueId: "f7fbf8c8-139b-4376-b307-cf0a8c2d0d9c",
		}

@update-docs
Copy link

update-docs bot commented Jun 23, 2022

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@micbar micbar force-pushed the space-id branch 15 times, most recently from 90747a9 to 0a203cf Compare July 7, 2022 07:08
@micbar
Copy link
Member Author

micbar commented Jul 7, 2022

Let us not merge before we update in ocis and run a full CI.

@micbar micbar mentioned this pull request Jul 8, 2022
9 tasks
@micbar micbar force-pushed the space-id branch 3 times, most recently from 319d726 to b6c997a Compare July 10, 2022 20:20
@butonic butonic marked this pull request as ready for review July 12, 2022 11:13
@butonic
Copy link
Contributor

butonic commented Jul 12, 2022

all ocis tests green excep flaky api tests: https://drone.owncloud.com/owncloud/ocis/13376/38/5

merging to create ocis update pr

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants