Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add missing error check in decomposedfs #3430

Merged
merged 2 commits into from
Nov 3, 2022

Conversation

butonic
Copy link
Contributor

@butonic butonic commented Nov 3, 2022

During space creation the decomposedfs now checks for errors when trying to read the root node. This prevents a panic by no longer calling InternalPath on the node.

Seen in the stacktrace of owncloud/ocis#4961

Signed-off-by: Jörn Friedrich Dreyer <[email protected]>
@micbar
Copy link
Member

micbar commented Nov 3, 2022

@butonic can you add this to get a green ci

diff --git a/.drone.star b/.drone.star
index a8f978798..f0d73896d 100644
--- a/.drone.star
+++ b/.drone.star
@@ -313,16 +313,6 @@ def coverage():
                     "make test",
                 ],
             },
-            {
-                "name": "codacy",
-                "image": "plugins/codacy:1",
-                "pull": "always",
-                "settings": {
-                    "token": {
-                        "from_secret": "codacy_token",
-                    },
-                },
-            },
         ],
         "depends_on": ["changelog"],
     }

Signed-off-by: Jörn Friedrich Dreyer <[email protected]>
@butonic butonic merged commit dda4d03 into cs3org:edge Nov 3, 2022
@butonic butonic deleted the decomposedfs-check-error branch November 3, 2022 13:26
@kobergj kobergj mentioned this pull request Dec 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants