Fix Public Link Path matching #3892
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: jkoberg <[email protected]>
kobergj
commented
May 16, 2023
| if childStat.Status.Code != rpc.Code_CODE_OK { | ||
| return false, statuspkg.NewErrorFromCode(childStat.Status.Code, "auth interceptor") | ||
| } | ||
| childPath = statResponse.Info.Path |
There was a problem hiding this comment.
NOTE this was an (unknown) critical bug.
parentPath := statResponse.Info.Path
( ... )
childPath = statResponse.Info.Path
( ... )
return strings.HasPrefix(childPath, parentPath), nil
kobergj
requested review from
labkode,
ishank011,
glpatcern and
a team
as code owners
micbar
reviewed
May 16, 2023
| // The request is not relative to the root. We need to find out if the requested resource is child of the `parent` (coming from token scope) | ||
| // We mint a token as the owner of the public share and try to stat the reference | ||
| // TODO(ishank011): We need to find a better alternative to this | ||
| // NOTE: did somebody say service accounts? ... |
This was referenced May 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes matching of pathes when resolving public links.
We need another
GetPathcall to get the necessary information.