usershareprovider: check permissions before updating a share #4405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhafer
force-pushed
the
update-share-permission-check
branch
from
0e65f79
to
f5bae4a
Compare
rhafer
force-pushed
the
update-share-permission-check
branch
2 times, most recently
from
464a335
to
36a0397
Compare
kobergj
requested changes
Dec 13, 2023
rhafer
force-pushed
the
update-share-permission-check
branch
from
36a0397
to
ce4471b
Compare
rhafer
force-pushed
the
update-share-permission-check
branch
3 times, most recently
from
7f9be5d
to
432d565
Compare
rhafer
added a commit
to rhafer/ocis
that referenced
this pull request
Dec 13, 2023
Instead of relying on the calling service for permission checks, we're now checking if the requesting user has sufficient permission for performing an update in the shareprovider itself.
Check the UpateShare call for success, before trying ot update the grants on the shared resource.
Bump golangci-lint to v1.55.2, the old version we had seems to cause issues with some go1.21 code. Also remove some deprecated linters that no longer seem to work correctly. Also bump setup-go to v4 (as in master).
rhafer
force-pushed
the
update-share-permission-check
branch
from
432d565
to
10fe3ba
Compare
rhafer
added a commit
to rhafer/ocis
that referenced
this pull request
Dec 14, 2023
rhafer
added a commit
to rhafer/ocis
that referenced
this pull request
Dec 14, 2023
|
@micbar This should be ready now. I also did a [full-ci] run on ocis with it (see https://drone.owncloud.com/owncloud/ocis/30043) |
micbar
approved these changes
Dec 15, 2023
kobergj
approved these changes
Dec 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of relying on the calling service for permission checks, we're now checking if the requesting user has sufficient permission for performing an update in the shareprovider itself.