Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V5 #333

Merged
merged 69 commits into from
Oct 11, 2024
Merged

V5 #333

merged 69 commits into from
Oct 11, 2024

Conversation

csandman
Copy link
Owner

@csandman csandman commented Sep 5, 2024

This PR implements a batch of prop changes that were all implemented in #322, along with a codemod to hopefully make the transition easier. Along with that, all of the examples have been migrated to StackBlitz due to the new limits implemented on CodeSandbox. Here are all of the changes to the props from #322:

This PR makes a few changes to the custom props this package offers which will be breaking changes.

  1. Removes the useBasicStyles prop, and defaults the styles to those that were previously provided by it. This is a change I've been meaning to make for a while, as I came to really dislike the default styles I gave the dropdown indicator. Originally, it was styled to match the InputRightAddon component, in order to create a visual separation between the dropdown indicator and the clear indicator. However, I grew to strongly dislike the way it visually clashed with the built-in select menu. Also, the original CodeSandbox example I provided for showing how to style the select more closely to the original Chakra select had more views than any other example sandbox that was provided, showing that this is how many people would prefer it to look anyway.
  2. Remove the deprecated selectedOptionColor prop. A new prop was added a while ago to replace that one, selectedOptionColorScheme, as some people were getting confused by the meaning of the original. So I took this opportunity to finally remove the old prop it replaced.
  3. Remove the deprecated hasStickyGroupHeaders prop. I removed this from the documentation a long time ago, as it was only ever really an experimental way to style the grouped option headers so they'd stay in view while you scroll the list of options. It also had some problems with using the keyboard to navigate between options. They would disappear behind the header when you used the up arrow. So this change is also a long time coming.
  4. Renamed the colorScheme prop to tagColorScheme. There has been some confusion around what this prop actually means, and I realized the original name the prop had wasn't specific enough to it's purpose. It didn't make sense to have a specific prop for selectedOptionColorScheme, and not be specific with the naming for the tagColorScheme.

All of these changes can be made automatically using the Codemod provided here


Besides the prop changes, a lot of the general config has been updated to be more recent, such as the TSConfig and GitHub actions

Copy link

github-actions bot commented Sep 5, 2024

📊 Package size report   -0.97%↓

File Before After
dist/index.d.mts 21.1 kB -5.71%↓19.9 kB
dist/index.d.ts 21.1 kB -5.71%↓19.9 kB
dist/index.js 16.5 kB -0.61%↓16.4 kB
dist/index.js.map 74.0 kB -0.65%↓73.5 kB
dist/index.mjs 15.1 kB -0.66%↓15.0 kB
dist/index.mjs.map 74.0 kB -0.65%↓73.5 kB
package.json 3.0 kB -3.01%↓2.9 kB
README.md 46.3 kB 2%↑47.4 kB
Total (Includes all files) 272.2 kB -0.97%↓269.5 kB
Tarball size 61.0 kB -1.09%↓60.4 kB
Unchanged files
File Size
LICENSE.md 1.1 kB

🤖 This report was automatically generated by pkg-size-action

@csandman csandman marked this pull request as ready for review October 11, 2024 22:56
@csandman csandman merged commit 55ececd into main Oct 11, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants