Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Convention.select_indexes() method #146

Merged
merged 5 commits into from
Jul 10, 2024
Merged

Add Convention.select_indexes() method #146

merged 5 commits into from
Jul 10, 2024

Commits on Jul 10, 2024

  1. Consistently use 'indexes' over 'indices' 

    Using both is confusing in public interfaces. 'indexes' was used in
public interfaces, while 'indices' was only used internally or as the
name of positional arguments. I think we can get away with renaming to
'indexes' without a deprecation cycle this way!
    @mx-moth
    mx-moth committed Jul 10, 2024
    Configuration menu
    Copy the full SHA
    a875a7a View commit details
    Browse the repository at this point in the history

  2. Add function emsarray.utils.find_unused_dimension()

    @mx-moth
    mx-moth committed Jul 10, 2024
    Configuration menu
    Copy the full SHA
    43fd43d View commit details
    Browse the repository at this point in the history

  3. Add Convention.select_indexes() and related functions 

    This is a breaking change for plugins as it changes the abstract methods
on the Convention class. `Convention.selector_for_indexes()` is a new
required method, and `Convention.selector_for_index()` now has a default
implementation which calls the new method.
    @mx-moth
    mx-moth committed Jul 10, 2024
    Configuration menu
    Copy the full SHA
    8e16424 View commit details
    Browse the repository at this point in the history

  4. Add release note

    @mx-moth
    mx-moth committed Jul 10, 2024
    Configuration menu
    Copy the full SHA
    081c313 View commit details
    Browse the repository at this point in the history

  5. fixup! Add Convention.select_indexes() and related functions

    @mx-moth
    mx-moth committed Jul 10, 2024
    Configuration menu
    Copy the full SHA
    b363826 View commit details
    Browse the repository at this point in the history