Treat :import and :export statements as pure. Fixes #21 #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #23 +/- ##
==========================================
+ Coverage 98.98% 99.00% +0.01%
==========================================
Files 2 2
Lines 296 301 +5
Branches 94 96 +2
==========================================
+ Hits 293 298 +5
Misses 3 3
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #21 and would resolve the related next.js tickets vercel/next.js#10142 and vercel/next.js#11629.
It seems incorrect to use something called
context.useLocalsfor this purpose, as way I am in this PR, but it's only used for the pure mode check, and I couldn't think of a more descriptive variable name. I'm open to any alternative approaches.