Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: node:vm syntax support in [email protected] #407

Merged
merged 1 commit into from
May 31, 2022
Merged

fix: node:vm syntax support in [email protected] #407

merged 1 commit into from
May 31, 2022

Conversation

zhangyuang
Copy link
Contributor

node:vm syntax will throw error cannot find module node:vm with [email protected]

@romainmenke
Copy link
Member

@zhangyuang This looks great! Thank you for also updating the rollup configs.
Running CI now.

@romainmenke romainmenke merged commit f70355b into csstools:main May 31, 2022
@romainmenke
Copy link
Member

Also tested in node 14 and this works.
We'll ship this out asap.

@Antonio-Laguna
Copy link
Member

@zhangyuang thanks a lot for your swift patch! This is now patched as 1.0.1, a fresh install of preset-env should bring it !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
common-tools plugins/postcss-trigonometric-functions PostCSS Trigonometric Functions
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zhangyuang @romainmenke @Antonio-Laguna