Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix -a being ignored #63

Open
wants to merge 1 commit into
base: v8
Choose a base branch
from
Open

Fix -a being ignored #63

wants to merge 1 commit into from

Conversation

pschmitt
Copy link
Contributor

I noticed that $APPEND_SYSTEM_PATH wasn't consumed anywhere and the Android system path was appended by default. This PR makes the -a flag work as described in the help.

@cswl
Copy link
Owner

cswl commented May 31, 2020

I should probably document this code... but this is intended..

The reason still being issue with some Android devices unable to load /system/binaries due to library linking error

@pschmitt
Copy link
Contributor Author

Wouldn't it make more sense to remove the flag altogether then?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants