Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gain Selection #197

Closed
vuillaut opened this issue Oct 31, 2019 · 2 comments
Closed

Gain Selection #197

vuillaut opened this issue Oct 31, 2019 · 2 comments

Comments

@vuillaut
Copy link
Member

gain selection is probably wrong.
See cta-observatory/ctapipe#1166

Quick fix: go back to the manual gain selection that is still in lstchain but noted as deprecated.
@HealthyPear HealthyPear mentioned this issue Nov 4, 2019
Closed
@rlopezcoto rlopezcoto mentioned this issue Dec 12, 2019
Closed
@rlopezcoto
Copy link
Contributor

Current threshold from the config file should be 20.9 (phe) instead of 4094 (counts) until next ctapipe version is realeased (currently following v0.7.0)

@maxnoe maxnoe mentioned this issue Apr 21, 2020
Open
18 tasks
@rlopezcoto rlopezcoto mentioned this issue May 18, 2020
Closed
@rlopezcoto
Copy link
Contributor

this should be solved in lstchain >= v0.6 that uses ctapipe v0.8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@vuillaut @rlopezcoto