-
Notifications
You must be signed in to change notification settings - Fork 267
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GainSelection should be applied to R0 waveform, not R1 #1166
Comments
Also, I suggest we change the |
Should the gain selection be applied after the mc pedestal subtraction (but before the mc.dc_to_pe is applied)? ctapipe/ctapipe/io/simteleventsource.py Line 282 in 5b81bb6
|
I did not realise this. |
@HealthyPear Is this issue solved since #1167? |
Since protopipe relies only on frozen releases of ctapipe, for the moment I hardcoded what I needed. What I did is the following,
What you decided to do is anyway better for the future, so as for any new feature in ctapipe, I will simply import it and get rid of my hardcoded part. |
fixed in #1167 |
Right now the
CameraCalibrator
applies the GainSelector (incalibrated_dl0()
) and it applies it to the R1 waveforms (which are in "rough photoelectrons" after the R1 calibration). This means that the threshold is calibration dependent (e.g. it's something like 7.0 photoelectrons/ns for an LST). In reality, this should be applied in the step from R0 → R1, where the threshold is in Digital Counts and thus the threshold for switching should be (2^12-1) = 4095 for a 12-bit ADC and assuming the front-end amplifiers are linear in the whole digitization range.I suggest we either:
That way we don't have to "calibrate" the gain threshold for each camera each time the DC/PE or pedestals change.
The text was updated successfully, but these errors were encountered: