Fix comparison of timestamps in calibration code #1002
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This code was comparing an astropy `TimeDelta` object to a plain number, which was supposed to be in seconds. However, astropy treats plain numbers as days, not seconds. Since astropy 5.1, this creates a warning and made me find this bug. See astropy/astropy#12887.
Codecov Report
@@ Coverage Diff @@
## master #1002 +/- ##
=======================================
Coverage 85.88% 85.88%
=======================================
Files 78 78
Lines 6645 6645
=======================================
Hits 5707 5707
Misses 938 938
Continue to review full report at Codecov.
|
FrancaCassol
approved these changes
Jul 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This code was comparing an astropy
TimeDeltaobject to a plain number,which was supposed to be in seconds. However, astropy treats plain
numbers as days, not seconds. Since astropy 5.1, this creates a warning
and made me find this bug. See
astropy/astropy#12887.
This means that in when calculating calibration coefficients, the condition for the sample duration was never met, only the number of events condition was used effectively.
I don't know if that has any consequences, since we right now analyze subrun by subrun and these are shorter than the default 60s sample duration value.