Require atleast ctapipe_io_lst 0.18.2

[maxnoe]

No description provided.

[maxnoe]

I had to add an option to r0_to_dl1 which I though already existed, to use trigger type TIB since the test run (2008) has occurences of UCTS trigger being 42 (STEREO BIT, SINGLE_PE Bit and PEDESTAL bit set).

After the update, this event was correctly labeled as UNKNOWN, but it was the only one previously tagged pedestal, so the test for the calculate noise parameters failed.

With default_trigger_type="tib", the one actual pedestal event in that file is found again and the test passes with a slight modification of the tested value.

Do we just not look at these old runs? What does osa do with runs like these where TIB would be the better choice?

@moralejo @morcuended

[codecov]

Codecov Report

Merging #1003 (c639be0) into master (7b967de) will decrease coverage by 0.41%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1003      +/-   ##
==========================================
- Coverage   85.75%   85.34%   -0.42%     
==========================================
  Files          78       78              
  Lines        6619     6645      +26     
==========================================
- Hits         5676     5671       -5     
- Misses        943      974      +31     

Impacted Files	Coverage Δ
lstchain/conftest.py	97.58% <ø> (ø)
lstchain/image/tests/test_modifier.py	100.00% <100.00%> (ø)
lstchain/scripts/tests/test_lstchain_scripts.py	99.64% <100.00%> (ø)
lstchain/calib/camera/calibration_calculator.py	51.72% <0.00%> (-41.38%)	⬇️
lstchain/calib/camera/flatfield.py	96.29% <0.00%> (ø)
lstchain/calib/camera/pedestals.py	95.69% <0.00%> (ø)
lstchain/tests/test_lstchain.py	97.00% <0.00%> (+0.03%)	⬆️
lstchain/reco/dl1_to_dl2.py	76.96% <0.00%> (+3.44%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7b967de...c639be0. Read the comment docs.

[morcuended]

Do we just not look at these old runs? What does osa do with runs like these where TIB would be the better choice?

We have been using default_trigger_type="ucts" for all the data runs. We do not perform any check to choose between tib or ucts source of information.

[maxnoe]

Ok, for me this mainly means that we should include a more recent file in the test data sample that doesn't have all these now solved issues.