Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

greater or equal filters in DL3Cuts #1015

Merged
merged 2 commits into from
Sep 17, 2022
Merged

greater or equal filters in DL3Cuts #1015

merged 2 commits into from
Sep 17, 2022

Conversation

vuillaut
Copy link
Member

I think a greater or equal operator is actually what we want here. For example, if a user requests an efficiency of 100%, I think he expects all events to be included, which is not the case atm.

I think a greater *or equal* operator is actually what we want here.
For example, if a user requests an efficiency of 100%, I think he expects all events to be included, which is not the case atm.
@rlopezcoto
Copy link
Contributor

One of the tests need to be modified for the CI to pass, otherwise, I agree with the proposed changes

@codecov
Copy link

codecov bot commented Sep 16, 2022

Codecov Report

Base: 71.54% // Head: 72.87% // Increases project coverage by +1.33% 🎉

Coverage data is based on head (e1ee014) compared to base (ef53179).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1015      +/-   ##
==========================================
+ Coverage   71.54%   72.87%   +1.33%     
==========================================
  Files         118      118              
  Lines       11251    11251              
==========================================
+ Hits         8049     8199     +150     
+ Misses       3202     3052     -150     
Impacted Files Coverage Δ
lstchain/io/event_selection.py 100.00% <ø> (ø)
lstchain/io/tests/test_eventselection.py 100.00% <100.00%> (ø)
lstchain/datachecks/dl1_checker.py 75.73% <0.00%> (+4.50%) ⬆️
lstchain/datachecks/containers.py 98.52% <0.00%> (+61.08%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@vuillaut vuillaut merged commit 61e0e24 into master Sep 17, 2022
@vuillaut vuillaut deleted the patch_operator branch September 17, 2022 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants