Set correct NSB tuning settings for low-zenith Crab MC #1025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NSB parameters are obtained with the fixed code for finding the NSB-tuning parameters (#1024). Note: the replaced parameters were very outdated, not obtained with the immediately earlier version, and were not those used for Crab in the analyses over the past few months. Also switched off obsolete optical PSF tuning.
Codecov ReportBase: 71.62% // Head: 71.62% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #1025 +/- ##
==========================================
- Coverage 71.62% 71.62% -0.01%
==========================================
Files 120 120
Lines 11302 11301 -1
==========================================
- Hits 8095 8094 -1
Misses 3207 3207
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
rlopezcoto
approved these changes
Oct 19, 2022
|
looks fine to me. |
jsitarek
approved these changes
Oct 19, 2022
moralejo
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NSB parameters are obtained with the fixed code for finding the NSB-tuning parameters (#1024). Note: the replaced parameters were very outdated, not obtained with the immediately earlier version, and were not those used for Crab in the analyses over the past few months.
Also switched off obsolete optical PSF tuning.