Estimate cleaning threshold with CatB pedestals if availables #1143
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1143 +/- ##
==========================================
- Coverage 74.32% 74.27% -0.05%
==========================================
Files 130 130
Lines 13245 13253 +8
==========================================
Hits 9844 9844
- Misses 3401 3409 +8 ☔ View full report in Codecov by Sentry. |
FrancaCassol
force-pushed
the
cleaning_with_CatB
branch
from
282f805
to
55f62d3
Compare
|
Hi @maxnoe, |
There was a problem hiding this comment.
Thanks @FrancaCassol. I left a few comments. Is it possible to implement a test for this?
|
Hi @morcuended, for implementing a test, we need first to merge PR #1147, in order to easily produce a catB calibration file. |
|
@FrancaCassol I resolved the conflicts, can you check if everything is alright? |
|
Hi @rlopezcoto, dl1_mon_tel_catB_ped_key = "/dl1/monitoring/telescope/catB/pedestal" or dl1_mon_tel_CatB_ped_key = "/dl1/monitoring/telescope/CatB/pedestal" |
|
in the hdf5 files merging script is still written as |
corrected now |
| if args.catB_calibration_file is not None: | ||
| catB_pedestal_mean = np.array(catB_pedestal["charge_mean"]) | ||
| catB_pedestal_std= np.array(catB_pedestal["charge_std"]) | ||
| catB_threshold_clean_pe = catB_pedestal_mean + sigma * catB_pedestal_std |
There was a problem hiding this comment.
Maybe these lines could be somehow integrated inside get_threshold_from_dl1_file, which I think does something similar.
There was a problem hiding this comment.
I agree that they could come in a function, but I think it would be better to have a different one because there will be cases in which you may want tio extract catB parameters instead of the regular ones, right?
In any case, I leave @FrancaCassol to decide if it is a good idea to put a pin on this for the future
No description provided.