Fix arrays not being masked correctly in flatfield calculator

[maxnoe]

No description provided.

[codecov]

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (e3368bd) 73.74% compared to head (d91e876) 73.75%.
Report is 1 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #1149   +/-   ##
=======================================
  Coverage   73.74%   73.75%           
=======================================
  Files         124      124           
  Lines       12586    12589    +3     
=======================================
+ Hits         9282     9285    +3     
  Misses       3304     3304           

Files Changed	Coverage Δ
lstchain/calib/camera/calibration_calculator.py	91.42% <100.00%> (+0.16%)	⬆️
lstchain/calib/camera/flatfield.py	96.69% <100.00%> (ø)
lstchain/calib/camera/pedestals.py	96.22% <100.00%> (ø)
lstchain/visualization/plot_calib.py	100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[maxnoe]

In the last commit, you remove the setting of values to True in the outlier arrays.

Are you sure, this does what we want?

In [3]: outliers = np.ma.array([True, False, True], mask=[True, True, False])

In [4]: np.ma.getdata(outliers)
Out[4]: array([ True, False,  True])

I guess we want all masked values be marked as outliers, right?

That would be:

In [5]: outliers.filled(True)
Out[5]: array([ True,  True,  True])

[FrancaCassol]

@maxnoe, I agree, change done