Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused get_cleaning_parameters function #1170

Merged
merged 1 commit into from
Nov 30, 2023
Merged

Conversation

aaguasca
Copy link
Collaborator

This PR removes the unused function get_cleaning_parameters from find_safe_threshold_from_dl1_file

@codecov
Copy link

codecov bot commented Sep 28, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (fd7e1a8) 74.46% compared to head (0ebe771) 73.98%.
Report is 301 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1170      +/-   ##
==========================================
- Coverage   74.46%   73.98%   -0.49%     
==========================================
  Files         124      124              
  Lines       12211    12645     +434     
==========================================
+ Hits         9093     9355     +262     
- Misses       3118     3290     +172     
Files Coverage Δ
...stchain/calib/camera/pixel_threshold_estimation.py 27.27% <ø> (-0.99%) ⬇️

... and 57 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@morcuended
Copy link
Member

This can be merged as well.

@rlopezcoto rlopezcoto merged commit d27e2fe into main Nov 30, 2023
8 of 9 checks passed
@rlopezcoto rlopezcoto deleted the unused_function branch November 30, 2023 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants