Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New script and notebook for the selection of good quality runs #1190

Merged
merged 19 commits into from
Jan 30, 2024

Conversation

moralejo
Copy link
Collaborator

@moralejo moralejo commented Dec 3, 2023

This will eventually replace the data_selection notebook for find good quality runs

intensity spectra and use them for the selection of good quality runs
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link

codecov bot commented Dec 3, 2023

Codecov Report

Attention: 277 lines in your changes are missing coverage. Please review.

Comparison is base (089891d) 74.22% compared to head (83f2b89) 72.76%.
Report is 27 commits behind head on main.

Files Patch % Lines
...stchain/scripts/lstchain_cherenkov_transparency.py 8.27% 277 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1190      +/-   ##
==========================================
- Coverage   74.22%   72.76%   -1.47%     
==========================================
  Files         130      131       +1     
  Lines       13279    13581     +302     
==========================================
+ Hits         9857     9882      +25     
- Misses       3422     3699     +277     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@morcuended morcuended left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left some comments and suggestions on the script

lstchain/scripts/lstchain_cherenkov_transparency.py Outdated Show resolved Hide resolved
lstchain/scripts/lstchain_cherenkov_transparency.py Outdated Show resolved Hide resolved
lstchain/scripts/lstchain_cherenkov_transparency.py Outdated Show resolved Hide resolved
lstchain/scripts/lstchain_cherenkov_transparency.py Outdated Show resolved Hide resolved
lstchain/scripts/lstchain_cherenkov_transparency.py Outdated Show resolved Hide resolved
lstchain/scripts/lstchain_cherenkov_transparency.py Outdated Show resolved Hide resolved
lstchain/scripts/lstchain_cherenkov_transparency.py Outdated Show resolved Hide resolved
lstchain/scripts/lstchain_cherenkov_transparency.py Outdated Show resolved Hide resolved
@moralejo moralejo marked this pull request as ready for review January 26, 2024 16:36
morcuended
morcuended previously approved these changes Jan 30, 2024
Copy link
Member

@morcuended morcuended left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me. I tested it for several sources and it works fine.

Copy link
Contributor

@rlopezcoto rlopezcoto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Already reviewed by @morcuended , just approving after a small comment implementation

@moralejo moralejo merged commit 1517320 into main Jan 30, 2024
7 of 9 checks passed
@moralejo moralejo deleted the cherenkov_transparency branch January 30, 2024 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants