-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New script and notebook for the selection of good quality runs #1190
Conversation
intensity spectra and use them for the selection of good quality runs
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1190 +/- ##
==========================================
- Coverage 74.22% 72.76% -1.47%
==========================================
Files 130 131 +1
Lines 13279 13581 +302
==========================================
+ Hits 9857 9882 +25
- Misses 3422 3699 +277 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left some comments and suggestions on the script
…herenkov_transparency
Added the identification of a few "typical subruns" in terms of NSB level
…pynb) to avoid confusions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine to me. I tested it for several sources and it works fine.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Already reviewed by @morcuended , just approving after a small comment implementation
This will eventually replace the data_selection notebook for find good quality runs