-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Likelihood reconstruction update #1200
Conversation
…d pixels removal in the likelihood reconstruction.
…log message and test.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1200 +/- ##
==========================================
- Coverage 72.92% 72.81% -0.12%
==========================================
Files 133 133
Lines 13885 13911 +26
==========================================
+ Hits 10126 10129 +3
- Misses 3759 3782 +23 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @gabemery I reviewed especially the part related to source-dependent analysis. I put the comments there
…_gradient and skewness even when the likelihood reconstruction is active
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the answers @gabemery
I approved the change of codes related to source-dependent analysis
This pull request covers 4 small changes:
All of these changes were already tested extensively in a modified version of lstchain 0.9.8
I also checked that it run successfully up to the creation of DL2 files in the current version on small v0.10 (no DVR) datasets (without in depth check of the file content). The updated config file fails during training due to #1206