Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit scipy to version before 1.12 which introduces a breaking change and unfreeze sphinx version #1201

Merged
merged 2 commits into from
Jan 22, 2024

Conversation

gabemery
Copy link
Collaborator

@gabemery gabemery commented Jan 22, 2024

The breaking change I encountered is fixed in gammapy main branch but not in a release yet.

Error during lstchain tests with the latest scipy :

../../../micromamba-root/envs/lst-dev/lib/python3.10/site-packages/gammapy/utils/roots.py:9: in <module>
   BAD_RES = RootResults(root=np.nan, iterations=0, function_calls=0, flag=0)
E   TypeError: RootResults.__init__() missing 1 required positional argument: 'method'

'method' is introduced in scipy 1.12.0

EDIT Daniel Morcuende: I unfreeze the version of sphinx that was being used (~4) because it was giving problems in the docs building:

Sphinx version error:
The sphinxcontrib.applehelp extension used by this project needs at least Sphinx v5.0; it therefore cannot be built with this version.

@gabemery gabemery added the bug Something isn't working label Jan 22, 2024
@gabemery gabemery self-assigned this Jan 22, 2024
Copy link

codecov bot commented Jan 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (089891d) 74.22% compared to head (acce0df) 74.22%.

❗ Current head acce0df differs from pull request most recent head 5811da6. Consider uploading reports for the commit 5811da6 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1201   +/-   ##
=======================================
  Coverage   74.22%   74.22%           
=======================================
  Files         130      130           
  Lines       13279    13279           
=======================================
  Hits         9857     9857           
  Misses       3422     3422           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

morcuended
morcuended previously approved these changes Jan 22, 2024
rlopezcoto
rlopezcoto previously approved these changes Jan 22, 2024
Copy link
Contributor

@rlopezcoto rlopezcoto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @gabemery ! I opened #1202 to remember that we can follow later scipy releases whenever we do it for gammapy

@morcuended morcuended dismissed stale reviews from rlopezcoto and themself via 5811da6 January 22, 2024 15:23
@morcuended morcuended changed the title Limit scipy to version before 1.12 which introduces a breaking change Limit scipy to version before 1.12 which introduces a breaking change and unfreeze sphinx version Jan 22, 2024
@rlopezcoto rlopezcoto merged commit 97efe2d into main Jan 22, 2024
7 checks passed
@rlopezcoto rlopezcoto deleted the fix_scipy_version branch January 22, 2024 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants