Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deal with missing modules in modifier.py #1204

Merged
merged 1 commit into from
Jan 22, 2024
Merged

Deal with missing modules in modifier.py #1204

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions lstchain/image/modifier.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -230,8 +230,8 @@ def calculate_noise_parameters(simtel_filename, data_dl1_filename,

# Identify noisy pixels, likely containing stars - we want to adjust MC to
# the average diffuse NSB across the camera
data_median_std_ped_pe = np.median(data_HG_ped_std_pe)
data_std_std_ped_pe = np.std(data_HG_ped_std_pe)
data_median_std_ped_pe = np.nanmedian(data_HG_ped_std_pe)
data_std_std_ped_pe = np.nanstd(data_HG_ped_std_pe)
log.info(f'Real data: median across camera of good pixels\' pedestal std '
f'{data_median_std_ped_pe:.3f} p.e.')
brightness_limit = data_median_std_ped_pe + 3 * data_std_std_ped_pe
Expand All @@ -247,7 +247,7 @@ def calculate_noise_parameters(simtel_filename, data_dl1_filename,
# Exclude too bright pixels, besides those with unusable calibration:
good_pixels &= ~too_bright_pixels
# recalculate the median of the pixels' std dev, with good_pixels:
data_median_std_ped_pe = np.median(data_HG_ped_std_pe[good_pixels])
data_median_std_ped_pe = np.nanmedian(data_HG_ped_std_pe[good_pixels])

log.info(f'Good and not too bright pixels: {good_pixels.sum()}')

Expand Down
Loading