Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docs related to data checks #1207

Merged
merged 19 commits into from
Jan 30, 2024
Merged

Update docs related to data checks #1207

merged 19 commits into from
Jan 30, 2024

Conversation

moralejo
Copy link
Collaborator

No description provided.

@moralejo
Copy link
Collaborator Author

WIP!

Copy link

codecov bot commented Jan 24, 2024

Codecov Report

Attention: 9 lines in your changes are missing coverage. Please review.

Comparison is base (107f8ce) 74.22% compared to head (e05ffe5) 74.21%.
Report is 2 commits behind head on main.

Files Patch % Lines
lstchain/scripts/lstchain_tune_nsb.py 16.66% 5 Missing ⚠️
lstchain/image/modifier.py 83.33% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1207      +/-   ##
==========================================
- Coverage   74.22%   74.21%   -0.02%     
==========================================
  Files         130      130              
  Lines       13279    13302      +23     
==========================================
+ Hits         9857     9872      +15     
- Misses       3422     3430       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Solved issue with lstchain_tune_nsb.py (gave error if 'image_modifier' key
did not exist in input config file!)
@moralejo
Copy link
Collaborator Author

moralejo commented Jan 29, 2024

I had to make a minor change in the script lstchain_tune_nsb.py, while writing the documentation I noticed it was not working as expected.
Also, some changes in image/modifier.py to deal properly with files having issues with the monitoring table.

@moralejo moralejo marked this pull request as ready for review January 30, 2024 00:16
@moralejo
Copy link
Collaborator Author

@vuillaut: I modified a bit the way the creation of the configuration file for the NSB tuning is built in the Workflow description.

@rlopezcoto rlopezcoto merged commit fac56f2 into main Jan 30, 2024
7 of 9 checks passed
@rlopezcoto rlopezcoto deleted the moralejo-datacheck-docs branch January 30, 2024 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants