Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix missing SinglePhE_ResponseInPhE_expo2Gaus.dat #1254

Merged
merged 12 commits into from
May 17, 2024

Conversation

vuillaut
Copy link
Member

This PR fixes #1253 by:

  • creating a function to get resource data from lstchain
  • setting the path to None by default in the config and looking for the default file path in this case

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@morcuended
Copy link
Member

pkg_resources is deprecated in favor of importlib.resources

@vuillaut vuillaut changed the title fix missing SinglePhE_ResponseInPhE_expo2Gaus.dat Draft: fix missing SinglePhE_ResponseInPhE_expo2Gaus.dat May 16, 2024
@vuillaut vuillaut marked this pull request as draft May 16, 2024 10:20
@vuillaut vuillaut changed the title Draft: fix missing SinglePhE_ResponseInPhE_expo2Gaus.dat fix missing SinglePhE_ResponseInPhE_expo2Gaus.dat May 16, 2024
lstchain/io/io.py Outdated Show resolved Hide resolved
Copy link

codecov bot commented May 16, 2024

Codecov Report

Attention: Patch coverage is 96.00000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 73.13%. Comparing base (53dff7e) to head (8cb517a).
Report is 1 commits behind head on main.

Current head 8cb517a differs from pull request most recent head 57a41d5

Please upload reports for the commit 57a41d5 to get more accurate results.

Files Patch % Lines
lstchain/visualization/bokeh.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1254      +/-   ##
==========================================
+ Coverage   73.11%   73.13%   +0.02%     
==========================================
  Files         134      134              
  Lines       14058    14058              
==========================================
+ Hits        10278    10282       +4     
+ Misses       3780     3776       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vuillaut vuillaut marked this pull request as ready for review May 16, 2024 22:40
Copy link
Member

@morcuended morcuended left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @vuillaut looks, good to me. I just left a comment

morcuended
morcuended previously approved these changes May 17, 2024
@vuillaut
Copy link
Member Author

Thanks for the review @morcuended
Sorry I made a last-minute change to make sure the default file is indeed used in the tests. Could you review again please?

@vuillaut vuillaut merged commit f1c0d77 into main May 17, 2024
7 checks passed
@vuillaut vuillaut deleted the fix_SinglePhE_ResponseInPhE_expo2Gaus branch May 17, 2024 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FileNotFoundError: lstchain/data/SinglePhE_ResponseInPhE_expo2Gaus.dat not found
3 participants