-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix missing SinglePhE_ResponseInPhE_expo2Gaus.dat #1254
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
pkg_resources is deprecated in favor of importlib.resources |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1254 +/- ##
==========================================
+ Coverage 73.11% 73.13% +0.02%
==========================================
Files 134 134
Lines 14058 14058
==========================================
+ Hits 10278 10282 +4
+ Misses 3780 3776 -4 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @vuillaut looks, good to me. I just left a comment
Thanks for the review @morcuended |
This PR fixes #1253 by: