Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the shape of the interpolated Effective Area #1270

Merged
merged 1 commit into from
Jun 26, 2024
Merged

Conversation

chaimain
Copy link
Contributor

Fixes #1269

@chaimain chaimain requested a review from IevgenVovk June 25, 2024 09:33
Copy link

codecov bot commented Jun 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.28%. Comparing base (609a977) to head (b9220bd).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1270   +/-   ##
=======================================
  Coverage   73.27%   73.28%           
=======================================
  Files         134      134           
  Lines       14081    14084    +3     
=======================================
+ Hits        10318    10321    +3     
  Misses       3763     3763           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@morcuended morcuended left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @chaimain. Looks good to me

@rlopezcoto rlopezcoto merged commit 7f92595 into main Jun 26, 2024
9 checks passed
@rlopezcoto rlopezcoto deleted the fix_interp_aeff branch June 26, 2024 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

interpolate_irfs reduces dimentions of EFFAREA IRF
3 participants