Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure consistency between the cis and runsummary tables #1279

Merged
merged 2 commits into from
Jul 22, 2024
Merged

Conversation

moralejo
Copy link
Collaborator

This was not working for >1 different runs between the tables because of improper use of panda's "drop"
Fixes #1277

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link

codecov bot commented Jul 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.35%. Comparing base (a12b12c) to head (5509986).
Report is 97 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1279   +/-   ##
=======================================
  Coverage   73.35%   73.35%           
=======================================
  Files         134      134           
  Lines       14117    14117           
=======================================
  Hits        10356    10356           
  Misses       3761     3761           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@moralejo moralejo merged commit 21d8f7e into main Jul 22, 2024
9 checks passed
@moralejo moralejo deleted the dataqual_nbook branch July 22, 2024 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AssertionError in data_quality.ipynb
2 participants