Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor scripts #203

Merged
merged 7 commits into from
Nov 5, 2019
Merged

Refactor scripts #203

merged 7 commits into from
Nov 5, 2019

Conversation

vuillaut
Copy link
Member

@vuillaut vuillaut commented Nov 5, 2019 •
edited
Loading

Following the discussion in PR #190, here is a small refactoring of lstchain scripts.

  • they now follow the data level steps (when relevant)
  • I tried to follow a mc vs data convention when possible
  • they are all renamed lstchain_something
  • they are all callable when lstchain is installed (so you can type anywhere lstchain_r0_to_dl1.py -f ...)

@vuillaut vuillaut mentioned this pull request Nov 5, 2019
Closed
@vuillaut vuillaut mentioned this pull request Nov 5, 2019
Closed
misabelber
misabelber approved these changes Nov 5, 2019
View reviewed changes
Copy link
Collaborator

@misabelber misabelber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks perfect to me, thank you!

@vuillaut vuillaut merged commit c8dd41b into cta-observatory:master Nov 5, 2019
@vuillaut vuillaut deleted the refactor_scripts branch November 5, 2019 14:47
@vuillaut vuillaut mentioned this pull request Nov 5, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@misabelber misabelber misabelber approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vuillaut @misabelber