Optimize pointing scripts #233
Conversation
| drive_container.altitude_avg = data['altitude_avg'].data | ||
| drive_container.time = drive_data['time'].data | ||
| drive_container.azimuth_avg = drive_data['azimuth_avg'].data | ||
| drive_container.altitude_avg = drive_data['altitude_avg'].data |
There was a problem hiding this comment.
do you think it would be worth reading the other data as well?
It could be used later to check that the pointing was not crazy... What do you think?
There was a problem hiding this comment.
do you think it would be worth reading the other data as well?
It could be used later to check that the pointing was not crazy... What do you think?
Yes, off course that would be good. In fact, the drive_data stores all information from the drive report. Only some of them are tagged as e,g. time, azimuth_avg, etc. Today we saw that the RA and DEC are also present in the Drive report. At present, there are no RA and DEC information in the DL1 files. They are indeed required for finer analysis and can be added as metadata in the DL1 file.
|
Looks much better :) |
|
Hi all, thanks a lot. I think the one @vuillaut proposed is a nice improvement and you can maybe add an issue to keep track of it. I'll merge this now and make a bugfix release for you to include this information in the real data analysis. |
As @vuillaut reported in #231, the code related to the addition of pointing information to the data stream was terribly slowing down the performance. It was basically reading the drive report file for every event.
@labsaha and I modified the code in order for the drive file to be open only once at the beginning of the script and buffer it to be used later on.
@labsaha, @vuillaut and @rlopezcoto can you please take a look at the modifications?