Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update muon script and calibration scripts #263

Merged
merged 19 commits into from
Jan 21, 2020
Merged

Update muon script and calibration scripts #263

merged 19 commits into from
Jan 21, 2020

Conversation

FrancaCassol
Copy link
Collaborator

This PR include

  • the muon script is updated with the new gain selection and with tel_id information in order to be able to run it on old data.
  • the calibration script get some new trailets which permit to select only the time or only the charge calibration
  • some other minors changes

@FrancaCassol
Correct pedestal statistics
88d595b
@FrancaCassol
Merge branch 'master' of https://github.com/cta-observatory/cta-lstchain
a06db3b 
 into correct_value
@FrancaCassol
Update muon script with calibrator and tel_id trailet in order to use
282f421 
it also for old data
@FrancaCassol
Merge branch 'master' of https://github.com/cta-observatory/cta-lstchain
713b1d6 
 into update_muon_script

Conflicts:
	lstchain/scripts/lstchain_data_muon_analysis.py
@FrancaCassol
Merge branch 'master' of https://github.com/cta-observatory/cta-lstchain
a81b541 
 into update_muon_script
@FrancaCassol
Change default values to standard one
b75da0b
@FrancaCassol
Eliminate run number information (replaced by tel_id)
facb985
@FrancaCassol
Merge branch 'master' of https://github.com/cta-observatory/cta-lstchain
3128682 
 into update_muon_script

Conflicts:
	lstchain/data/onsite_camera_calibration_param.json
	lstchain/scripts/lstchain_data_muon_analysis.py
	lstchain/scripts/onsite/onsite_create_calibration_file.py
	lstchain/tools/lstchain_data_create_calibration_file.py
@FrancaCassol
Add trailets to select only the time calibraiton or the flat field ca…
2abc79d 
…libration
@FrancaCassol
Get geometry infos from the event_source class
cfc1b91
@FrancaCassol
Merge remote-tracking branch 'upstream/master' into update_muon_script
77be762
@FrancaCassol
Add tel_id for processing old files
d0cda0a
@FrancaCassol
Add trailet tel_id for processing old files
1fb27b6
@FrancaCassol
Remove unused trailet
8f49833
@FrancaCassol
Update geometry
d32b0d2
@FrancaCassol
Add check on tel_id value
8f631b5
@FrancaCassol
Add tel_id argument in order to run on old data
2da23ed
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

You'll be able to see Jupyter notebook diff and discuss changes. Powered by ReviewNB.

@rlopezcoto
Copy link
Contributor

So this one cancels #241?

@FrancaCassol
Copy link
Collaborator Author

Ops, yes, I will close it

@FrancaCassol FrancaCassol mentioned this pull request Jan 20, 2020
Closed
@FrancaCassol
Add a default_time_run trailet to identifay the time calibrarion file…
d0b2315 
…: the script create a link to the corresponding calibration file.

If the trailet is zero, the script calculate the time calibraiton
@FrancaCassol
Add trailet default_time_run and create a link to the time calibratio…
24c5d30 
…n file of that run.

If default_time_run=0, it calculate the time calibration file.
@FrancaCassol
Copy link
Collaborator Author

FrancaCassol commented Jan 20, 2020 •
edited
Loading

Concerning the time calibration file, after discussion with @rlopezcoto the idea is to create for each night a link (in the calibration directory) to the correct time calibration file. This is performed by the onsite_create_calibration_script.
The action is steered by the trailet "defaut_time_run". If this trailet is set to zero, the script calculates the time calibration from the data of that night otherwise performs the link. The default value of the trailet is now 1625 with is the run suggested by Pawel as a good time run.

@rlopezcoto
Copy link
Contributor

Hi @FrancaCassol, changes look good to me. This needs to be merged before the next release, so I'll leave it here for a while in case somebody has a comment, otherwise I'll merge it tonight.

@FrancaCassol
Copy link
Collaborator Author

ok!

@rlopezcoto rlopezcoto merged commit a2aabbf into cta-observatory:master Jan 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rlopezcoto rlopezcoto rlopezcoto approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@FrancaCassol @rlopezcoto