Update read_LST1_data.ipynb #280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Please find this reviewed version of the notebook. The previous one was reporting: tel.optics.mirror_type -> AttributeError: 'OpticsDescription' object has no attribute 'mirror_type'. I removed it, and now it works smoothly. Thank you
|
Check out this pull request on You'll be able to see Jupyter notebook diff and discuss changes. Powered by ReviewNB. |
|
Thanks @lfoffano for the corrections! |
Thank you, Ruben! I updated the file accordingly
|
Thank you, Ruben! |
rlopezcoto
approved these changes
Feb 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please find this reviewed version of the notebook. The previous one was reporting: tel.optics.mirror_type -> AttributeError: 'OpticsDescription' object has no attribute 'mirror_type'.
I removed it, and now it works smoothly. Only this difference has been applied.
Thank you