Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change conda env name #289

Merged
merged 5 commits into from
Feb 17, 2020

Conversation

calispac
Copy link
Contributor

As the title suggests this changes the name of the conda environment from "cta" to "lstchain".
I think "cta" is too generic. I hope this does not affects user who got the habit to do conda activate cta.

@calispac
Copy link
Contributor Author

This is ready to be reviewed/accepted + eventually merged.

Copy link
Member

@vuillaut vuillaut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi.
I think you are right that cta is not well chosen.
However I would propose lst-dev to be inline with ctapipe and to avoid confusion of users new to conda and co, between the library and the environment.

@calispac
Copy link
Contributor Author

Hi ! Ok thanks it is changed

@rlopezcoto
Copy link
Contributor

what about lstchain-dev?

README.md Outdated Show resolved Hide resolved
@vuillaut
Copy link
Member

Seems good to me.
lst-dev is specific and short enough in my opinion.

@rlopezcoto rlopezcoto merged commit 320f34d into cta-observatory:master Feb 17, 2020
@calispac calispac deleted the change_conda_env_name branch February 17, 2020 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants