Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removing intercept from configs #309

Merged
merged 2 commits into from
Mar 24, 2020

Conversation

vuillaut
Copy link
Member

No description provided.

@morcuended
Copy link
Member

Looking at the lstchain_standard_config_keep_all_events.json file I realize that it's no longer up to date. It needs to be either updated or entirely removed.

@vuillaut
Copy link
Member Author

Looking at the lstchain_standard_config_keep_all_events.json file I realize that it's no longer up to date. It needs to be either updated or entirely removed.

Ok, thanks for the check.
Is it used at all? (if not I'd remove it to keep things cleaner)

@morcuended
Copy link
Member

Ok, thanks for the check.
Is it used at all? (if not I'd remove it to keep things cleaner)

I would say that not anymore

@rlopezcoto
Copy link
Contributor

the config to keep all events, is it really unused @morcuended?

@morcuended
Copy link
Member

the config to keep all events, is it really unused @morcuended?

I'm not using it at least. Just the standard config file or a modified one if a different cleaning setting is required. But not exactly this one that became outdated quite some time ago.

@rlopezcoto
Copy link
Contributor

ok, so I agree to remove it to avoid confusion, thanks @vuillaut

@vuillaut vuillaut merged commit 51622c6 into cta-observatory:master Mar 24, 2020
@vuillaut vuillaut deleted the remove_intercept branch March 24, 2020 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants