Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused imports and fix docstring location #315

Merged
merged 2 commits into from
Apr 6, 2020

Conversation

maxnoe
Copy link
Member

@maxnoe maxnoe commented Apr 1, 2020

No description provided.

vuillaut
vuillaut previously approved these changes Apr 1, 2020
@rlopezcoto
Copy link
Contributor

Maybe the same here as #312, this may be in conflict with #304...

@maxnoe
Copy link
Member Author

maxnoe commented Apr 1, 2020

Yes, but it's a small change and #304 needs conflict resolution anyways

@rlopezcoto
Copy link
Contributor

Ok, so let's wait on @moralejo's opinion so we can decide where to merge them

@rlopezcoto
Copy link
Contributor

After merging #304, could you please revise this and #312? There are currently conflicts and some of this was already implemented

@codecov
Copy link

codecov bot commented Apr 6, 2020

Codecov Report

Merging #315 into master will increase coverage by 0.09%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #315      +/-   ##
==========================================
+ Coverage   41.73%   41.83%   +0.09%     
==========================================
  Files          69       69              
  Lines        4771     4762       -9     
==========================================
+ Hits         1991     1992       +1     
+ Misses       2780     2770      -10     
Impacted Files Coverage Δ
...stchain/scripts/lstchain_data_muon_analysis_dl1.py 0.00% <0.00%> (ø)
lstchain/mc/sensitivity.py 98.64% <0.00%> (+0.33%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 62d122d...042ca01. Read the comment docs.

@maxnoe
Copy link
Member Author

maxnoe commented Apr 6, 2020

@rlopezcoto I rebased vs master

@vuillaut vuillaut merged commit 875a29c into cta-observatory:master Apr 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants