Update env #333
Update env #333
Conversation
Codecov Report
@@ Coverage Diff @@
## master #333 +/- ##
==========================================
+ Coverage 42.88% 43.59% +0.70%
==========================================
Files 70 69 -1
Lines 4694 4618 -76
==========================================
Hits 2013 2013
+ Misses 2681 2605 -76
Continue to review full report at Codecov.
|
|
@rlopezcoto sorry, I pushed another commit, you'll need to approve again |
| @@ -40,10 +40,16 @@ def find_scripts(script_dir, prefix): | |||
| packages=find_packages(), | |||
| py_modules='version', | |||
| install_requires=[ | |||
| 'astropy', | |||
There was a problem hiding this comment.
this is going to install the latest astropy (4.0), right?
There was a problem hiding this comment.
It's the same as in the environment file (no version specification).
If astropy is already installed in any version, it won't update, if it is not installed it will install the latest version.
There was a problem hiding this comment.
I was wondering whether we would need to implement any modification if this was required (as it was done in ctapipe), but I guess that Travis is testing it now with 4.0 since we are not specifying anything, right?
There was a problem hiding this comment.
looking into the log, astropy 3.2 is installed
There was a problem hiding this comment.
That is a bit strange. Seems it's because of conda-forge.
There was a problem hiding this comment.
ok, shall we merge this and open another one forcing astropy 4.0 in case there are some things that need to be modified?
No description provided.