Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix a couple of things with scripts #341

Merged
merged 5 commits into from
Apr 10, 2020
Merged

Conversation

vuillaut
Copy link
Member

  • unused import
  • better path management
  • an issue with main in r0 to dl2 + test

@codecov
Copy link

codecov bot commented Apr 10, 2020

Codecov Report

Merging #341 into master will increase coverage by 0.08%.
The diff coverage is 27.27%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #341      +/-   ##
==========================================
+ Coverage   43.59%   43.67%   +0.08%     
==========================================
  Files          69       69              
  Lines        4618     4623       +5     
==========================================
+ Hits         2013     2019       +6     
+ Misses       2605     2604       -1     
Impacted Files Coverage Δ
lstchain/scripts/lstchain_dl1_to_dl2.py 0.00% <0.00%> (ø)
lstchain/scripts/lstchain_mc_dl1ab.py 0.00% <ø> (ø)
lstchain/scripts/lstchain_mc_r0_to_dl1.py 0.00% <0.00%> (ø)
lstchain/scripts/lstchain_mc_r0_to_dl2.py 0.00% <0.00%> (ø)
lstchain/scripts/tests/test_lstchain_scripts.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cc51d7e...fb1c467. Read the comment docs.

@vuillaut vuillaut merged commit 54a4e36 into cta-observatory:master Apr 10, 2020
@vuillaut vuillaut deleted the r0_dl2 branch April 10, 2020 18:19
@maxnoe maxnoe mentioned this pull request Apr 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants