Apply volume reduction to non gain selected waveforms #342
Conversation
Codecov Report
@@ Coverage Diff @@
## master #342 +/- ##
==========================================
- Coverage 43.67% 43.65% -0.02%
==========================================
Files 69 69
Lines 4623 4625 +2
==========================================
Hits 2019 2019
- Misses 2604 2606 +2
Continue to review full report at Codecov.
|
| @@ -75,7 +75,6 @@ def check_and_apply_volume_reduction(event, config): | |||
| pass | |||
|
|
|||
| else: | |||
| print("Volume reduction algorithm being used: {}".format(volume_reduction_algorithm)) | |||
There was a problem hiding this comment.
Not really against or in favor (just matter of tastes). But why taking out the stdout message ? It is true that to apply the vol_reduc, you must had consciously modified the config file... But this would be just a double check of what are you doing/applying int the analysis
There was a problem hiding this comment.
There shouldn't be any prints in the code base. If you want to keep this message, use the logging module (debug or info for this)
| @@ -92,7 +91,12 @@ def check_and_apply_volume_reduction(event, config): | |||
|
|
|||
| image[~pixels_to_keep] = 0 | |||
| pulse_time[~pixels_to_keep] = 0 | |||
| waveform[~pixels_to_keep, :] = 0 | |||
| if waveform.ndim == 2: | |||
There was a problem hiding this comment.
do we still have cases in which we do not apply gain selection or this is just for testing purposes?
There was a problem hiding this comment.
We actually do not apply gain selection in real data currently (in the sense that we currently keep both channels).
There was a problem hiding this comment.
ok, sorry this is for R0 data
There was a problem hiding this comment.
yeah, I meant before we apply gain selection (for DL1)
There was a problem hiding this comment.
So if it's fine with you, I'd like to merge this
No description provided.