Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dl2 naming #345

Merged
merged 7 commits into from
Apr 17, 2020
Merged

Conversation

rlopezcoto
Copy link
Contributor

I open this one apart from #344 to see if everybody agrees. I'm not sure why in the dl2 file naming we kept dl1, as in:
dl2_dl1_LST-1...

I propose to eliminate the dl1 part for the future naming of dl2 files

morcuended
morcuended previously approved these changes Apr 16, 2020
@codecov
Copy link

codecov bot commented Apr 17, 2020

Codecov Report

Merging #345 into master will not change coverage.
The diff coverage is 50.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #345   +/-   ##
=======================================
  Coverage   43.67%   43.67%           
=======================================
  Files          69       69           
  Lines        4623     4623           
=======================================
  Hits         2019     2019           
  Misses       2604     2604           
Impacted Files Coverage Δ
lstchain/scripts/lstchain_dl1_to_dl2.py 0.00% <0.00%> (ø)
lstchain/scripts/tests/test_lstchain_scripts.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f4c8df9...4c49174. Read the comment docs.

@rlopezcoto
Copy link
Contributor Author

Thanks for the approval @morcuended and sorry, but I had to solve some conflicts before merging (need another approval)

@rlopezcoto rlopezcoto merged commit 5c8914a into cta-observatory:master Apr 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants