Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing requirements to setup.py #385

Merged
merged 2 commits into from
Apr 30, 2020
Merged

Add missing requirements to setup.py #385

merged 2 commits into from
Apr 30, 2020

Conversation

maxnoe
Copy link
Member

@maxnoe maxnoe commented Apr 30, 2020

Note: I did not add ctapipe_io_lst as this would prevent the pypi upload, as currently ctapipe_io_lst cannot be uploaded to pypi.

vuillaut
vuillaut previously approved these changes Apr 30, 2020
rlopezcoto
rlopezcoto previously approved these changes Apr 30, 2020
@maxnoe maxnoe dismissed stale reviews from rlopezcoto and vuillaut via 78c96cb April 30, 2020 10:37
@codecov
Copy link

codecov bot commented Apr 30, 2020

Codecov Report

Merging #385 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #385   +/-   ##
=======================================
  Coverage   44.53%   44.53%           
=======================================
  Files          64       64           
  Lines        4655     4655           
=======================================
  Hits         2073     2073           
  Misses       2582     2582           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 24d81bc...78c96cb. Read the comment docs.

@maxnoe maxnoe merged commit a683e45 into master Apr 30, 2020
@maxnoe maxnoe deleted the install_requires branch April 30, 2020 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants