Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add generic path parsing function, factor out match conversion #400

Merged
merged 2 commits into from
May 11, 2020

Conversation

maxnoe
Copy link
Member

@maxnoe maxnoe commented May 5, 2020

No description provided.

@codecov
Copy link

codecov bot commented May 5, 2020

Codecov Report

Merging #400 into master will increase coverage by 0.17%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #400      +/-   ##
==========================================
+ Coverage   41.26%   41.44%   +0.17%     
==========================================
  Files          76       76              
  Lines        6126     6143      +17     
==========================================
+ Hits         2528     2546      +18     
+ Misses       3598     3597       -1     
Impacted Files Coverage Δ
lstchain/paths.py 90.62% <100.00%> (+1.15%) ⬆️
lstchain/tests/test_paths.py 100.00% <100.00%> (ø)
lstchain/mc/sensitivity.py 98.64% <0.00%> (+0.33%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 359018b...7343dc5. Read the comment docs.

@rlopezcoto
Copy link
Contributor

Just seen this PR, maybe this could have been brought up here.

@rlopezcoto rlopezcoto mentioned this pull request May 6, 2020
@rlopezcoto rlopezcoto merged commit 5e24dd6 into master May 11, 2020
@rlopezcoto rlopezcoto deleted the more_paths branch May 11, 2020 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants